Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXF-98764: Add Sanity FCR to VD connections #111

Merged
merged 5 commits into from
Aug 23, 2024
Merged

CXF-98764: Add Sanity FCR to VD connections #111

merged 5 commits into from
Aug 23, 2024

Conversation

d-bhola
Copy link
Collaborator

@d-bhola d-bhola commented Aug 8, 2024

-Update workflow to add secrets in GHA
-Add FCR to VD test in prod sanity suite
-Add FCR to VD test in UAT sanity suite

thogarty
thogarty requested changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested change.

.github/workflows/terratests-prod-suite-all.yaml Outdated
@@ -29,6 +29,7 @@ jobs:
TEST_DATA_PROD_VIRTUAL_DEVICE_2_WAN_CONNECTION: ${{ secrets.TEST_DATA_PROD_VIRTUAL_DEVICE_2_WAN_CONNECTION }}
TEST_DATA_PROD_VIRTUAL_DEVICE_2_AZURE_CONNECTION: ${{secrets.TEST_DATA_PROD_VIRTUAL_DEVICE_2_AZURE_CONNECTION}}
TEST_DATA_PROD_VIRTUAL_DEVICE_2_PORT_CONNECTION: ${{secrets.TEST_DATA_PROD_VIRTUAL_DEVICE_2_PORT_CONNECTION}}
TEST_DATA_PROD_CLOUD_ROUTER_2_VIRTUAL_DEVICE_CONNECTION: ${{secrets.TEST_DATA_PROD_CLOUD_ROUTER_2_VIRTUAL_DEVICE_CONNECTION}}
Copy link
Collaborator

@thogarty thogarty Aug 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the secret names next to their neighbors. Same with the jq and echo statements as well. That way it's clear to see the list with a quick glance without spending more time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed with this commit

@d-bhola
Copy link
Collaborator Author

d-bhola commented Aug 19, 2024

UAT sanity is passing. Prod is failing due to the following error. (Linked this ticket to the existing bug ticket for Dragons)


 ---[ REQUEST ]---------------------------------------
POST /fabric/v4/connections HTTP/1.1
Host: api.equinix.com
User-Agent: HashiCorp Terraform/1.8.5 (+https://www.terraform.io) Terraform Plugin SDK/v2.34.0 terraform-provider-equinix/2.3.2 equinix-sdk-go/0.42.0
Content-Length: 504
Accept: application/json
Content-Type: application/json
X-Correlation-Id: 3CBRcn&$MSZJd90hxGwR9r#cO
X-Source: API
Accept-Encoding: gzip
                                2024-08-19T14:33:55.875-0700 [DEBUG] provider.terraform-provider-equinix_v2.3.2
{
 "aSide": {
  "accessPoint": {
   "router": {
    "uuid": "1f764d24-b400-4ef6-b3ba-3787bb5da7a7"
   },
   "type": "CLOUD_ROUTER"
  }
 },
 "bandwidth": 50,
 "name": "fcr_2_vd",
 "notifications": [
  {
   "emails": [
    "example@equinix.com",
    "test1@equinix.com"
   ],
   "type": "ALL"
  }
 ],
 "order": {
  "purchaseOrderNumber": "1-323292"
 },
 "redundancy": {
  "priority": "PRIMARY"
 },
 "type": "IP_VC",
 "zSide": {
  "accessPoint": {
   "interface": {
    "id": 5,
    "type": "NETWORK",
    "uuid": ""
   },
   "type": "VD",
   "virtualDevice": {
    "href": "",
    "name": "",
    "type": "EDGE",
    "uuid": "37cf3ffb-d436-4163-97c5-8f3607b4334a"
   }
  }
 }
}
2024-08-19T14:33:55.875-0700 [DEBUG] provider.terraform-provider-equinix_v2.3.2
-----------------------------------------------------
2024/08/19 14:33:58 [DEBUG] Equinix API Response Details:
---[ RESPONSE ]--------------------------------------
HTTP/1.1 500 Internal Server Error
Connection: close
Cache-Control: no-cache, no-store, max-age=0, must-revalidate
Content-Type: application/json
Correlationid: YT1ElvNNg6NHB2gK
Date: Mon, 19 Aug 2024 21:33:58 GMT
Expires: 0
Pragma: no-cache
Server: istio-envoy
Vary: Accept-Encoding
X-Apigee-Dp-Color: 174
X-Apigee-Environment: extprod
X-Apigee-Message-Id: a0343787-1d27-497d-b4c1-abde019e121d
X-Apigee-Organization: eqx-apg-prod
X-Apigee-Proxy: /organizations/eqx-apg-prod/environments/extprod/apiproxies/ecxv4/revisions/9
X-Apigee-Proxy-Basepath: /fabric/v4
X-Apigee-Region: us-west1
X-Apigee-Target-Latency: 1696
X-Content-Type-Options: nosniff
X-Envoy-Upstream-Service-Time: 1706
X-Frame-Options: DENY
X-Request-Id: a0343787-1d27-497d-b4c1-abde019e121d
X-Xss-Protection: 1; mode=block
                                2024-08-19T14:33:58.207-0700 [DEBUG] provider.terraform-provider-equinix_v2.3.2
[
 {
  "errorCode": "EQ-4014404",
  "errorMessage": "Get Port failed",
  "help": "https://<domain.name>/help/error/EQ-4014404",
  "details": "Please open a support ticket via the ? on the bottom of every page for further assistance.",
  "additionalInfo": [
   {}
  ]
 }
]

@d-bhola d-bhola requested a review from thogarty August 21, 2024 17:50
@d-bhola d-bhola marked this pull request as ready for review August 21, 2024 17:54
thogarty
thogarty reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-bhola , just some confusion about UAT user. Rest looks good.

tests/uat/uat_sanity_suite_test.go Show resolved Hide resolved
thogarty
thogarty approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@thogarty thogarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging.

@thogarty thogarty merged commit 94b3d97 into main Aug 23, 2024
0 of 2 checks passed
@thogarty thogarty deleted the CXF-98764-fcr-vd-sanity branch August 23, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thogarty thogarty thogarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-bhola @thogarty